<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="813978751" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2645" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2645/hovercard" href="https://github.com/kamailio/kamailio/issues/2645">#2645</a></li>
</ul>
<h4>Description</h4>
<p>For <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="813978751" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2645" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2645/hovercard" href="https://github.com/kamailio/kamailio/issues/2645">#2645</a>, a patch was pushed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/47b45b60a037808a675f7d52dd5b2ee80bfe0868/hovercard" href="https://github.com/kamailio/kamailio/commit/47b45b60a037808a675f7d52dd5b2ee80bfe0868"><tt>47b45b6</tt></a>, but this code does not correctly check the return value of <code>str2ip6buf</code> and <code>str2ipbuf</code>.</p>
<p>As described in the comments on both methods, they return zero <em>for success</em>.</p>
<p>This MR should be backported to 5.4 as well.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2695'>https://github.com/kamailio/kamailio/pull/2695</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix ip parsing in ipops</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2695/files#diff-9fed158a8da7c2e49be3c3b414a021005062a07b261f7de2ad6daa3f1066b6fb">src/modules/ipops/ipops_mod.c</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2695.patch'>https://github.com/kamailio/kamailio/pull/2695.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2695.diff'>https://github.com/kamailio/kamailio/pull/2695.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2695">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIOKHYUDSXWTKANDYDTF62HBANCNFSM4Z6PKXXQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZM43TVCZLEP3DSTV2DTF62HBA5CNFSM4Z6PKXX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MR4ZJQQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2695",
"url": "https://github.com/kamailio/kamailio/pull/2695",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>