[sr-dev] [kamailio/kamailio] support subscribe dialog (topos + topos_redis) (#2662)

fgaisnon notifications at github.com
Mon Mar 8 16:15:49 CET 2021


<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x ] Commit message has the format required by CONTRIBUTING guide
- [x ] Commits are split per component (core, individual modules, libs, utils, ...)
- [x ] Each component has a single commit (if not, squash them into one commit)
- [x ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x ] Small bug fix (non-breaking change which fixes an issue)
- [x ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
topos_redis: support SUBSCRIBE dialog
topos: SUBSCRIBE dialog
topos: documentation for SUBSCRIBE dialog
topos: add description for dialog_expire key

Add support for dialog subscribe when using topos.
When a Subscribe is received, a Subscribe dialog is created. Dialog TTL is set according to expire received in SIP request.
At each resubscribe the TTL is refresh according to expires set in SIP request.
Notify (in-dialog) with header event set are supposed to be inside a Subscribe dialog.

bugfix:
topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part
In this case we have a sip uri like : sip:@host

htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2662

-- Commit Summary --

  * topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part
  * topos_redis: support SUBSCRIBE dialog
  * htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated

-- File Changes --

    M src/modules/htable/htable.c (4)
    M src/modules/topos/doc/topos.xml (9)
    M src/modules/topos/doc/topos_admin.xml (7)
    M src/modules/topos/tps_msg.c (5)
    M src/modules/topos/tps_storage.c (41)
    M src/modules/topos/tps_storage.h (2)
    M src/modules/topos_redis/doc/topos_redis.xml (9)
    M src/modules/topos_redis/topos_redis_storage.c (75)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2662.patch
https://github.com/kamailio/kamailio/pull/2662.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2662
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210308/beca42dd/attachment.htm>


More information about the sr-dev mailing list