<h4>Pre-Submission Checklist</h4>
<ul>
<li>[x ] Commit message has the format required by CONTRIBUTING guide</li>
<li>[x ] Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li>[x ] Each component has a single commit (if not, squash them into one commit)</li>
<li>[x ] No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li>[x ] Small bug fix (non-breaking change which fixes an issue)</li>
<li>[x ] New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li>[x ] Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>topos_redis: support SUBSCRIBE dialog<br>
topos: SUBSCRIBE dialog<br>
topos: documentation for SUBSCRIBE dialog<br>
topos: add description for dialog_expire key</p>
<p>Add support for dialog subscribe when using topos.<br>
When a Subscribe is received, a Subscribe dialog is created. Dialog TTL is set according to expire received in SIP request.<br>
At each resubscribe the TTL is refresh according to expires set in SIP request.<br>
Notify (in-dialog) with header event set are supposed to be inside a Subscribe dialog.</p>
<p>bugfix:<br>
topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part<br>
In this case we have a sip uri like : sip:<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/host/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/host">@host</a></p>
<p>htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/2662'>https://github.com/kamailio/kamailio/pull/2662</a></p>
<h4>Commit Summary</h4>
<ul>
<li>topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part</li>
<li>topos_redis: support SUBSCRIBE dialog</li>
<li>htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-3749304d2a3e32568d710c207b2f30a1f03de5690e9c884cd1394f93efcceaad">src/modules/htable/htable.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-bc184d549a2b12da7c016190032d477d2840b9f7ee15068551c7c80fab618642">src/modules/topos/doc/topos.xml</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-56120be695d8db7a299deec08996f350abad1e136cb240f2c8a056297175f830">src/modules/topos/doc/topos_admin.xml</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-4893f4a6fac37179b81e7d548a4fa0ef7f5e2f19f0f6739625cc617a4cd33cf5">src/modules/topos/tps_msg.c</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-30475fa4aaeb5e7c5d9e3d35e437ebcd037a00cd59b0f32693265a6fe260a007">src/modules/topos/tps_storage.c</a>
(41)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-8c1bece089e858a13b457bc020dafb4ce135606228918d5eb1accb6a4dfda50c">src/modules/topos/tps_storage.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-8db10b6e3fab96c4d6669e30bf1b85f673df9e6d656bddbe3cab304ed28ce1a7">src/modules/topos_redis/doc/topos_redis.xml</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2662/files#diff-0b165731e54abd9275cd8032b909d95ac81841ddb208e991e971e92ef3819893">src/modules/topos_redis/topos_redis_storage.c</a>
(75)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/2662.patch'>https://github.com/kamailio/kamailio/pull/2662.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/2662.diff'>https://github.com/kamailio/kamailio/pull/2662.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2662">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPIFVUAI355ZR6UPGTTCTS2LANCNFSM4YZSMMAQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZIIBNZA4JJNDK2DY6DTCTS2LA5CNFSM4YZSMMA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MJHJVJQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2662",
"url": "https://github.com/kamailio/kamailio/pull/2662",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>