[sr-dev] [kamailio/kamailio] Rfc3264 on session (#2813)

lazedo notifications at github.com
Thu Aug 5 13:45:38 CEST 2021


#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->
some user agents send a=sendonly as a session attribute and is_audio_on_hold() returns false when it should return true.

#### Changes
- changed sdp_session_cell struct in sdp.h to add sendrecv_mode and is_on_hold
- changed parse_sdp_session in sdp.c to iterate session attributes and call extract_sendrecv_mode for assigment to session
- changed ki_is_audio_on_hold in textops.c to look for session sendrecv_mode if its not set in media




You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2813

-- Commit Summary --

  * core: parse session sendrecv_mode in sdp
  * textops: check session sendrecv_mode in is_audio_on_hold

-- File Changes --

    M src/core/parser/sdp/sdp.c (12)
    M src/core/parser/sdp/sdp.h (2)
    M src/modules/textops/textops.c (7)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2813.patch
https://github.com/kamailio/kamailio/pull/2813.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2813
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210805/e70cfd2c/attachment.htm>


More information about the sr-dev mailing list