<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>

<p>some user agents send a=sendonly as a session attribute and is_audio_on_hold() returns false when it should return true.</p>
<h4>Changes</h4>
<ul>
<li>changed sdp_session_cell struct in sdp.h to add sendrecv_mode and is_on_hold</li>
<li>changed parse_sdp_session in sdp.c to iterate session attributes and call extract_sendrecv_mode for assigment to session</li>
<li>changed ki_is_audio_on_hold in textops.c to look for session sendrecv_mode if its not set in media</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2813'>https://github.com/kamailio/kamailio/pull/2813</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>core: parse session sendrecv_mode in sdp</li>
  <li>textops: check session sendrecv_mode in is_audio_on_hold</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2813/files#diff-ceffb276cfbfbd846d9ea0177050d08e0ed476a5c46a5156bbd4b7dd0017b041">src/core/parser/sdp/sdp.c</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2813/files#diff-bffc719c35c14f5cd7ef17bf2796b0eec0816805569a3eed93f7c1590ad944a4">src/core/parser/sdp/sdp.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2813/files#diff-7f7f6a7e1a417b8f1d49f4061b784767d1c5044de1df72d4e06e59c6ce54fa1e">src/modules/textops/textops.c</a>
    (7)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2813.patch'>https://github.com/kamailio/kamailio/pull/2813.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2813.diff'>https://github.com/kamailio/kamailio/pull/2813.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2813">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZN7M236STGCVXKV7XTT3J2WFANCNFSM5BTV36SA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/ABO7UZMEMSMQJXKOACZ6JW3T3J2WFA5CNFSM5BTV36SKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OKS7SKQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2813",
"url": "https://github.com/kamailio/kamailio/pull/2813",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>