[sr-dev] [kamailio/kamailio] extensions to lost and http_client modules (#2675)

[Wolfgang Kampichler]

> @wkampich Thanks for the update. I think the comments regarding the missing original copyright notice in the natptr.[c,h] files and also the response.h naming are not resolved yet. The copyright notice should be added, I can also do it later if you prefer this.
> Regarding the naming comment, I just wanted to let you know that there might be a risk for overlapping data structures, as the s_info_t, s_data_t, cat_t etc.. are pretty generic and might be also defined in another library or module. The typedefs like LIST, INFO, DATA etc.. are in C also globally visible. For this reasons modules usually use the module prefix as part of the typedef, e.g.:
> 
>     * typedef enum rms_action_type
> 
>     * typedef struct _sr_lua_env
> 
>     * typedef struct ipsec_pcscf_api
> 
> 
> Several of this typedefs seems to be also not used in your code. But if you think its no big deal for your module, fine.

@henningw: Thanks for the reminder - I'll include your naming and copyright suggestions in a new commit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2675#issuecomment-815986078
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210408/f48a1512/attachment.htm>