<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/wkampich/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wkampich">@wkampich</a> Thanks for the update. I think the comments regarding the missing original copyright notice in the natptr.[c,h] files and also the response.h naming are not resolved yet. The copyright notice should be added, I can also do it later if you prefer this.<br>
Regarding the naming comment, I just wanted to let you know that there might be a risk for overlapping data structures, as the s_info_t, s_data_t, cat_t etc.. are pretty generic and might be also defined in another library or module. The typedefs like LIST, INFO, DATA etc.. are in C also globally visible. For this reasons modules usually use the module prefix as part of the typedef, e.g.:</p>
<pre><code>* typedef enum rms_action_type

* typedef struct _sr_lua_env

* typedef struct ipsec_pcscf_api
</code></pre>
<p>Several of this typedefs seems to be also not used in your code. But if you think its no big deal for your module, fine.</p>
</blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/henningw/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/henningw">@henningw</a>: Thanks for the reminder - I'll include your naming and copyright suggestions in a new commit.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2675#issuecomment-815986078">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZLIXPDWTLDYQIO2ODDTHXOHNANCNFSM4ZGSJGLQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZNQ4EEUSQ73AWYMCLDTHXOHNA5CNFSM4ZGSJGL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGCRPLHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2675#issuecomment-815986078",
"url": "https://github.com/kamailio/kamailio/pull/2675#issuecomment-815986078",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>