[sr-dev] [kamailio/kamailio] core: DNS stop resolving NAPTR for IP addresses (#2541)

Semen Darienko notifications at github.com
Thu Nov 5 15:07:11 CET 2020


@sem32 commented on this pull request.



> @@ -3292,6 +3292,9 @@ inline static int dns_naptr_sip_resolve(struct dns_srv_handle* h,  str* name,
 		}
 		try_lookup_naptr = 1;
 	}
+	/* check if it's an ip address, dns_srv_sip_resolve will return the right failure */

@jchavanton, can you give an example for your case?
I suppose that your check will never work, because we have the same check in line 3279 for first call of dns_naptr_sip_resolve

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524293363
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20201105/c353861b/attachment.htm>


More information about the sr-dev mailing list