<p></p>
<p><b>@sem32</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2541#discussion_r518076064">src/core/dns_cache.c</a>:</p>
<pre style='color:#555'>> @@ -3292,6 +3292,9 @@ inline static int dns_naptr_sip_resolve(struct dns_srv_handle* h,  str* name,
                }
                try_lookup_naptr = 1;
        }
+       /* check if it's an ip address, dns_srv_sip_resolve will return the right failure */
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/jchavanton/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jchavanton">@jchavanton</a>, can you give an example for your case?<br>
I suppose that your check will never work, because we have the same check in line 3279 for first call of dns_naptr_sip_resolve</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524293363">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZN2B36YCEI6K246GVTSOKWQ7ANCNFSM4TKRVY4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZO7IQSQE44N5QRPMPDSOKWQ7A5CNFSM4TKRVY4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD5ABJ4Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524293363",
"url": "https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524293363",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>