[sr-dev] git:5.3:ef221027: pdb: use memcpy() for PDB_BUFTOSHORT macro

[Daniel-Constantin Mierla]

Module: kamailio
Branch: 5.3
Commit: ef221027a448d77337225e376362b26b2618f050
URL: https://github.com/kamailio/kamailio/commit/ef221027a448d77337225e376362b26b2618f050

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2020-06-08T19:43:18+02:00

pdb: use memcpy() for PDB_BUFTOSHORT macro

- related to GH #2345

(cherry picked from commit be57be33d0e48d412ddab9801ee4d6d906329d70)

---

Modified: src/modules/pdb/pdb.c

---

Diff:  https://github.com/kamailio/kamailio/commit/ef221027a448d77337225e376362b26b2618f050.diff
Patch: https://github.com/kamailio/kamailio/commit/ef221027a448d77337225e376362b26b2618f050.patch

---

diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c
index 1ab15af2e7..5fb1204e52 100644
--- a/src/modules/pdb/pdb.c
+++ b/src/modules/pdb/pdb.c
@@ -190,7 +190,7 @@ static int pdb_msg_format_send(struct pdb_msg *msg,
 
 
 /* two chars to short-int without caring of memory alignment in char buffer */
-#define PDB_BUFTOSHORT(_b, _n) (((short int)_b[_n]) << 8) | (0x00ff & _b[_n+1])
+#define PDB_BUFTOSHORT(_sv, _b, _n) memcpy(&(_sv), (char*)(_b) + (_n), sizeof(short int))
 
 /*!
  * \return 1 if query for the number succeded and the avp with the corresponding carrier id was set,
@@ -347,7 +347,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
                                 case PDB_CODE_OK:
                                     msg.bdy.payload[sizeof(struct pdb_bdy) - 1] = '\0';
                                     if (strcmp(msg.bdy.payload, number.s) == 0) {
-                                        _id = PDB_BUFTOSHORT(msg.bdy.payload, reqlen); /* make gcc happy */
+                                        PDB_BUFTOSHORT(_id, msg.bdy.payload, reqlen); /* make gcc happy */
                                         carrierid=ntohs(_id); /* convert to host byte order */
                                         goto found;
                                     }
@@ -370,7 +370,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
                         default:
                             buf[sizeof(struct pdb_msg) - 1] = '\0';
                             if (strncmp(buf, number.s, number.len) == 0) {
-                                _id = PDB_BUFTOSHORT(buf, reqlen); /* make gcc happy */
+                                PDB_BUFTOSHORT(_id, buf, reqlen); /* make gcc happy */
                                 carrierid=ntohs(_id); /* convert to host byte order */
                                 goto found;
                             }