[sr-dev] git:master:a0fb220a: db2_local: replace timelocal() with mktime()

Daniel-Constantin Mierla miconda at gmail.com
Mon Apr 27 09:04:43 CEST 2020


Module: kamailio
Branch: master
Commit: a0fb220a8b60b135cabf6741882437317116d868
URL: https://github.com/kamailio/kamailio/commit/a0fb220a8b60b135cabf6741882437317116d868

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2020-04-27T09:00:21+02:00

db2_local: replace timelocal() with mktime()

- timelocal() is nonstandard GNU extension, not recommended to be used
and mktime() should be equivalent:
  * https://linux.die.net/man/3/timegm
- GH #2298

---

Modified: src/modules/db2_ldap/ld_fld.c

---

Diff:  https://github.com/kamailio/kamailio/commit/a0fb220a8b60b135cabf6741882437317116d868.diff
Patch: https://github.com/kamailio/kamailio/commit/a0fb220a8b60b135cabf6741882437317116d868.patch

---

diff --git a/src/modules/db2_ldap/ld_fld.c b/src/modules/db2_ldap/ld_fld.c
index 867c873e8f..7af731f077 100644
--- a/src/modules/db2_ldap/ld_fld.c
+++ b/src/modules/db2_ldap/ld_fld.c
@@ -270,7 +270,7 @@ static inline int ldap_gentime2db_datetime(time_t* dst, str* src)
 		 * of expiration by one hour when daylight saving is used
 		 */
 		time.tm_isdst = -1;
-		*dst = timelocal(&time);
+		*dst = mktime(&time);
 	}
 	
 	return 0;




More information about the sr-dev mailing list