[sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

Daniel-Constantin Mierla notifications at github.com
Wed Apr 22 10:50:09 CEST 2020


@miconda commented on this pull request.



>  	}
 
 	sip_trace_store(&sto, info->uriState == STRACE_PARSED_URI ? &info->u.dest_info : NULL, NULL);
+
+end:
+	if (faked && parsed_f) 
+		free_from(msg->from->parsed);

At least for safety,  probably `msg->from->parsed` should be set back to NULL, not to be freed again in other places.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397977288
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20200422/3e048d70/attachment.html>


More information about the sr-dev mailing list