<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2295#discussion_r412795419">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>>      }
 
        sip_trace_store(&sto, info->uriState == STRACE_PARSED_URI ? &info->u.dest_info : NULL, NULL);
+
+end:
+       if (faked && parsed_f) 
+               free_from(msg->from->parsed);
</pre>
<p>At least for safety,  probably <code>msg->from->parsed</code> should be set back to NULL, not to be freed again in other places.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397977288">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZP2EJKNP4MUUXLOXHLRN2VUDANCNFSM4MN6SM7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZLWOEEZO5LKWXDRA3TRN2VUDA5CNFSM4MN6SM72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC64KNSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397977288",
"url": "https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397977288",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>