[sr-dev] sip_trace() broken in master

[Henning Westerholt]

Hi Daniel,

sure - I was more referring to the timeline (tomorrow) then to the 
change in its self. ;-)

Cheers,

Henning

Am 01.10.19 um 10:39 schrieb Daniel-Constantin Mierla:
> Hello,
>
> given the changes done in the module to track the message, transaction
> or dialog, it should be fine to do this right now, because it is the
> testing period for 5.3, where it is supposed to clean up of issue and
> make coherent the new changes for this release. It is not like a new
> brand feature, only how an existing feature can be used in config.
>
> Once there will be a release, removing the flag option won't be ok,
> because that can break existing configs in a stable release, right now
> we are still before such milestone.
>
> Cheers,
> Daniel
>
> On 01.10.19 10:11, Henning Westerholt wrote:
>> Hi Daniel,
>>
>> I like your suggestion about replacing the flag option with a function.
>> This duplication is IMHO another potential to confuse users, I see this
>> for the dialog module also frequently (dlg_flag vs. dlg_manage() )
>>
>> If this change is to late for 5.3.0 - we could consider it for the next
>> development cycle.
>>
>> Cheers,
>>
>> Henning
>>
>> Am 30.09.19 um 20:22 schrieb Daniel-Constantin Mierla:
>>> Can you try with latest master? I pushed a commit that hopefully fixes it.
>>>
>>> On the other hand, the use of flag looks like no longer necessary if
>>> tracing mode parameter is set to 't'. Would it be acceptable to just add
>>> a new function sip_trace_mode() that will accept one parameter to
>>> specify what to track (message, transaction, dialog)? It would be a
>>> short form of sip_trace() with 3 parameters, when the two are not
>>> needed. I think it would be more coherent for the future to get rid of
>>> using also the message flag for tracking the transaction.
>>>
>>> Cheers,
>>> Daniel
>>>
>>> On 30.09.19 18:00, Juha Heinanen wrote:
>>>> Daniel-Constantin Mierla writes:
>>>>
>>>>> It is about storing in database? Or also mirroring?
>>>> Storing to db.  Don't know about mirroring.
>>>>
>>>> -- Juha

-- 
Kamailio Merchandising - https://skalatan.de/merchandising/
Kamailio services - https://skalatan.de/services
Henning Westerholt - https://skalatan.de/blog/