[sr-dev] sip_trace() broken in master

Henning Westerholt hw at skalatan.de
Tue Oct 1 10:11:46 CEST 2019


Hi Daniel,

I like your suggestion about replacing the flag option with a function. 
This duplication is IMHO another potential to confuse users, I see this 
for the dialog module also frequently (dlg_flag vs. dlg_manage() )

If this change is to late for 5.3.0 - we could consider it for the next 
development cycle.

Cheers,

Henning

Am 30.09.19 um 20:22 schrieb Daniel-Constantin Mierla:
> Can you try with latest master? I pushed a commit that hopefully fixes it.
>
> On the other hand, the use of flag looks like no longer necessary if
> tracing mode parameter is set to 't'. Would it be acceptable to just add
> a new function sip_trace_mode() that will accept one parameter to
> specify what to track (message, transaction, dialog)? It would be a
> short form of sip_trace() with 3 parameters, when the two are not
> needed. I think it would be more coherent for the future to get rid of
> using also the message flag for tracking the transaction.
>
> Cheers,
> Daniel
>
> On 30.09.19 18:00, Juha Heinanen wrote:
>> Daniel-Constantin Mierla writes:
>>
>>> It is about storing in database? Or also mirroring?
>> Storing to db.  Don't know about mirroring.
>>
>> -- Juha

-- 
Kamailio Merchandising - https://skalatan.de/merchandising/
Kamailio services - https://skalatan.de/services
Henning Westerholt - https://skalatan.de/blog/



More information about the sr-dev mailing list