[sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

Daniel-Constantin Mierla notifications at github.com
Fri Nov 15 21:05:11 CET 2019


miconda commented on this pull request.



> @@ -47,7 +47,10 @@
 #define SIP_VERSION_LEN 7
 
 #define HTTP_VERSION "HTTP/1."
-#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1)
+#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1)

Was the above change somehow done unintentionally? Because I see no reason to have `HTTP_VERSION_LEN` be based on size of `HTTP*2*_VERSION` value.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2132#pullrequestreview-317842091
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20191115/e7ad718c/attachment.html>


More information about the sr-dev mailing list