<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2132#discussion_r346990861">src/core/parser/parse_fline.h</a>:</p>
<pre style='color:#555'>> @@ -47,7 +47,10 @@
 #define SIP_VERSION_LEN 7
 
 #define HTTP_VERSION "HTTP/1."
-#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1)
+#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1)
</pre>
<p>Was the above change somehow done unintentionally? Because I see no reason to have <code>HTTP_VERSION_LEN</code> be based on size of <code>HTTP*2*_VERSION</code> value.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2132?email_source=notifications&email_token=ABO7UZICSG757LJ2Q6XCJKDQT36HPA5CNFSM4JN2IMRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLY6FKY#pullrequestreview-317842091">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMQST25IAMWPXRZVGDQT36HPANCNFSM4JN2IMRA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZMDRBBTZ2WBZTBLVQDQT36HPA5CNFSM4JN2IMRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLY6FKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2132?email_source=notifications\u0026email_token=ABO7UZICSG757LJ2Q6XCJKDQT36HPA5CNFSM4JN2IMRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLY6FKY#pullrequestreview-317842091",
"url": "https://github.com/kamailio/kamailio/pull/2132?email_source=notifications\u0026email_token=ABO7UZICSG757LJ2Q6XCJKDQT36HPA5CNFSM4JN2IMRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLY6FKY#pullrequestreview-317842091",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>