[sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[Tsvetomir Dimitrov]

tdimitrov commented on this pull request.

Great job! 

Only one remark - could you please address my comment about the hardcoded PROTO_UDP in ipsec_forward function? If it is not an error - I'll merge it.

> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
     struct pcontact_info ci;
     pcontact_t* pcontact = NULL;
     int ret = IPSEC_CMD_FAIL; // FAIL by default
+    unsigned char dst_proto = PROTO_UDP;

Is this hardcoded to PROTO_UDP on purpose?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#pullrequestreview-245615615
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190604/becf5337/attachment.html>