<p><b>@tdimitrov</b> commented on this pull request.</p>

<p>Great job!</p>
<p>Only one remark - could you please address my comment about the hardcoded PROTO_UDP in ipsec_forward function? If it is not an error - I'll merge it.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1974#discussion_r290428060">src/modules/ims_ipsec_pcscf/cmd.c</a>:</p>
<pre style='color:#555'>> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
     struct pcontact_info ci;
     pcontact_t* pcontact = NULL;
     int ret = IPSEC_CMD_FAIL; // FAIL by default
+    unsigned char dst_proto = PROTO_UDP;
</pre>
<p>Is this hardcoded to PROTO_UDP on purpose?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1974?email_source=notifications&email_token=ABO7UZIM4HENO6SNNDECS7TPY2WMTA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2R4X7Y#pullrequestreview-245615615">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIVFVXUREBOWEO5PKLPY2WMTANCNFSM4HSZHHVQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZNTP33IBWG5DRWRBA3PY2WMTA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2R4X7Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1974?email_source=notifications\u0026email_token=ABO7UZIM4HENO6SNNDECS7TPY2WMTA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2R4X7Y#pullrequestreview-245615615",
"url": "https://github.com/kamailio/kamailio/pull/1974?email_source=notifications\u0026email_token=ABO7UZIM4HENO6SNNDECS7TPY2WMTA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2R4X7Y#pullrequestreview-245615615",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>