[sr-dev] [kamailio/kamailio] error: 'pkg/docker' does not have a commit checked out (#2003)

[sergey-safarov]

Hi Daniel @miconda, Victor @linuxmaniac
Yes, when used sub-modules, then main repo contains references to other repos.
Before commit into `pkg/docker` folder (sub-module) need git-clone referenced repos too.
In this case need git-clone `kamailio/kamailio-ci` repo.
Examples how it can be done exist here:
1) https://git-scm.com/book/en/v2/Git-Tools-Submodules
2) https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules

> I open this item to see if we really need the to have pkg/docker submodule, or better have the docker files directly in the repo.

About reason to create dedicated repo. Please look email discussion with threads: 
```
Sep 27, 2017 -  Docker stuff
Nov 7, 2017 - docker continuous integration image
```
Some Daniel sentences from this threads
> As I am more involved in managing kamailio project repo on github I need to study a bit more and see the impact. As I said, my plan was to restructure/clean parts of the pkg (e.g., removing ser folder and unmaintaned specs, with a plan to discuss if it is better to relocate even the kamailio specs because more and more distros appear out there, some maintained for longer time, some not...).

For me is acceptable two cases for docker-ci image packaging scripts:
1) external repo + submodule in main repo;
2) all in main repo.

If you make decision to remove sub-module then I can create PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2003#issuecomment-509317994
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190708/9465104d/attachment-0001.html>