<p>Hi Daniel <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=184809" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/miconda">@miconda</a>, Victor <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=63080" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/linuxmaniac">@linuxmaniac</a><br>
Yes, when used sub-modules, then main repo contains references to other repos.<br>
Before commit into <code>pkg/docker</code> folder (sub-module) need git-clone referenced repos too.<br>
In this case need git-clone <code>kamailio/kamailio-ci</code> repo.<br>
Examples how it can be done exist here:</p>
<ol>
<li><a href="https://git-scm.com/book/en/v2/Git-Tools-Submodules" rel="nofollow">https://git-scm.com/book/en/v2/Git-Tools-Submodules</a></li>
<li><a href="https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules" rel="nofollow">https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules</a></li>
</ol>
<blockquote>
<p>I open this item to see if we really need the to have pkg/docker submodule, or better have the docker files directly in the repo.</p>
</blockquote>
<p>About reason to create dedicated repo. Please look email discussion with threads:</p>
<pre><code>Sep 27, 2017 -  Docker stuff
Nov 7, 2017 - docker continuous integration image
</code></pre>
<p>Some Daniel sentences from this threads</p>
<blockquote>
<p>As I am more involved in managing kamailio project repo on github I need to study a bit more and see the impact. As I said, my plan was to restructure/clean parts of the pkg (e.g., removing ser folder and unmaintaned specs, with a plan to discuss if it is better to relocate even the kamailio specs because more and more distros appear out there, some maintained for longer time, some not...).</p>
</blockquote>
<p>For me is acceptable two cases for docker-ci image packaging scripts:</p>
<ol>
<li>external repo + submodule in main repo;</li>
<li>all in main repo.</li>
</ol>
<p>If you make decision to remove sub-module then I can create PR.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/2003?email_source=notifications&email_token=ABO7UZLG622XQFYX2A4Q2L3P6N2EHA5CNFSM4H65DR62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNZG2Q#issuecomment-509317994">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOVXE7BARS7OPJFRCLP6N2EHANCNFSM4H65DR6Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZIORKYJNO6ALEBTJ33P6N2EHA5CNFSM4H65DR62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNZG2Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/issues/2003?email_source=notifications\u0026email_token=ABO7UZLG622XQFYX2A4Q2L3P6N2EHA5CNFSM4H65DR62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNZG2Q#issuecomment-509317994",
"url": "https://github.com/kamailio/kamailio/issues/2003?email_source=notifications\u0026email_token=ABO7UZLG622XQFYX2A4Q2L3P6N2EHA5CNFSM4H65DR62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNZG2Q#issuecomment-509317994",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>