[sr-dev] [kamailio/kamailio] modules: fix hiredis handling (#1816)

Daniel-Constantin Mierla notifications at github.com
Mon Jan 28 12:42:16 CET 2019


Did you have issues compiling?

Iirc, we tested to get this solution and at least the deb packages built fine for the past months since this change, after having couple of builds failed back then.

What it tries to do is that if pkg-config for cflags is not giving a path that has `hiredis` in it, then include `<hiredis/hiredis.h>`. If what pkg-config returns has `hiredis`, then just include `<hiredis.h>`.

I got on different systems and versions, either (1):

```
-I/opt/local/include/hiredis
```

or (2):

```
-I/opt/local/include
```

So for (1), include `<hiredis.h>` and for (2), include `<hiredis/hiredis.h>`.

Am I wrong in what is doing it right now?

Maybe there is something else to fix, but I find the current behaviour as expected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1816#issuecomment-458099087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190128/c950f408/attachment-0001.html>


More information about the sr-dev mailing list