<p>Did you have issues compiling?</p>
<p>Iirc, we tested to get this solution and at least the deb packages built fine for the past months since this change, after having couple of builds failed back then.</p>
<p>What it tries to do is that if pkg-config for cflags is not giving a path that has <code>hiredis</code> in it, then include <code><hiredis/hiredis.h></code>. If what pkg-config returns has <code>hiredis</code>, then just include <code><hiredis.h></code>.</p>
<p>I got on different systems and versions, either (1):</p>
<pre><code>-I/opt/local/include/hiredis
</code></pre>
<p>or (2):</p>
<pre><code>-I/opt/local/include
</code></pre>
<p>So for (1), include <code><hiredis.h></code> and for (2), include <code><hiredis/hiredis.h></code>.</p>
<p>Am I wrong in what is doing it right now?</p>
<p>Maybe there is something else to fix, but I find the current behaviour as expected.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1816#issuecomment-458099087">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36Zb3cCR1ZRVpx_VpHwxt63RjCoMp-ks5vHuIYgaJpZM4aJi6K">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZSStK4m2P1rYHFp0uyzlQkuKJYIKks5vHuIYgaJpZM4aJi6K.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1816: Did you have issues compiling?\r\n\r\nIirc, we tested to get this solution and at least the deb packages built fine for the past months since this change, after having couple of builds failed back then.\r\n\r\nWhat it tries to do is that if pkg-config for cflags is not giving a path that has `hiredis` in it, then include `\u003chiredis/hiredis.h\u003e`. If what pkg-config returns has `hiredis`, then just include `\u003chiredis.h\u003e`.\r\n\r\nI got on different systems and versions, either (1):\r\n\r\n```\r\n-I/opt/local/include/hiredis\r\n```\r\n\r\nor (2):\r\n\r\n```\r\n-I/opt/local/include\r\n```\r\n\r\nSo for (1), include `\u003chiredis.h\u003e` and for (2), include `\u003chiredis/hiredis.h\u003e`.\r\n\r\nAm I wrong in what is doing it right now?\r\n\r\nMaybe there is something else to fix, but I find the current behaviour as expected."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1816#issuecomment-458099087"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1816#issuecomment-458099087",
"url": "https://github.com/kamailio/kamailio/pull/1816#issuecomment-458099087",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>