[sr-dev] [kamailio/kamailio] nathelper: test sdp c line and sip source ip address is matched. (#2045)

[Yasin CANER]

> First a note for who is going to merge: the last commit doesn't have proper formatted commit message. So this PR should be squashed and merged or merged manually.
> 
> Then, I need a clarification: when this test is true: when all IPs in SDP match the source IP? If my logic is not missing something, the ip_addr_cmp() returns true if the two ips are the same, but you return -1 in that case.

yes ofc. If Connection Line IP address in SDP is matched  with SIP source address, there isnt any problem about NAT. 
For example;

UE has 192.168.1.18
A Router that  has ability Source NAT . so translate SIP Source IP address to 192.168.16.1

UE SIP request address is 192.168.16.1, Connection Lİne 192.168.1.18  so RTP flows cannot reach to UE. For solution , we add to rtpengine_manage function "SIP Source Address" flag.

256 flag helps to understand this scenario.

I will add more information to document.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-525208294
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190827/48fdbb87/attachment.html>