<blockquote>
<p>First a note for who is going to merge: the last commit doesn't have proper formatted commit message. So this PR should be squashed and merged or merged manually.</p>
<p>Then, I need a clarification: when this test is true: when all IPs in SDP match the source IP? If my logic is not missing something, the ip_addr_cmp() returns true if the two ips are the same, but you return -1 in that case.</p>
</blockquote>
<p>yes ofc. If Connection Line IP address in SDP is matched  with SIP source address, there isnt any problem about NAT.<br>
For example;</p>
<p>UE has 192.168.1.18<br>
A Router that  has ability Source NAT . so translate SIP Source IP address to 192.168.16.1</p>
<p>UE SIP request address is 192.168.16.1, Connection Lİne 192.168.1.18  so RTP flows cannot reach to UE. For solution , we add to rtpengine_manage function "SIP Source Address" flag.</p>
<p>256 flag helps to understand this scenario.</p>
<p>I will add more information to document.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2045?email_source=notifications&email_token=ABO7UZOQ3MNDFFDFVAVDHJLQGTT4VA5CNFSM4IPMS3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HAVZQ#issuecomment-525208294">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJDTW6OMQ7QUUP6H2DQGTT4VANCNFSM4IPMS3XQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZL5NSPX5MKWVG2GLXTQGTT4VA5CNFSM4IPMS3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HAVZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2045?email_source=notifications\u0026email_token=ABO7UZOQ3MNDFFDFVAVDHJLQGTT4VA5CNFSM4IPMS3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HAVZQ#issuecomment-525208294",
"url": "https://github.com/kamailio/kamailio/pull/2045?email_source=notifications\u0026email_token=ABO7UZOQ3MNDFFDFVAVDHJLQGTT4VA5CNFSM4IPMS3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HAVZQ#issuecomment-525208294",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>