[sr-dev] git:master:fd17c99e: siptrace: check if a request is set to avoid local transaction crash

[Henning Westerholt]

Module: kamailio
Branch: master
Commit: fd17c99eea3e41c087b8c73467608fd90ae37420
URL: https://github.com/kamailio/kamailio/commit/fd17c99eea3e41c087b8c73467608fd90ae37420

Author: iionita <ionut-razvan.ionita at 1and1.ro>
Committer: Henning Westerholt <henningw at users.noreply.github.com>
Date: 2019-04-09T21:25:53+02:00

siptrace: check if a request is set to avoid local transaction crash

---

Modified: src/modules/siptrace/siptrace.c

---

Diff:  https://github.com/kamailio/kamailio/commit/fd17c99eea3e41c087b8c73467608fd90ae37420.diff
Patch: https://github.com/kamailio/kamailio/commit/fd17c99eea3e41c087b8c73467608fd90ae37420.patch

---

diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c
index 242c4ab92b..ae1f53d7f3 100644
--- a/src/modules/siptrace/siptrace.c
+++ b/src/modules/siptrace/siptrace.c
@@ -1690,6 +1690,17 @@ static void trace_dialog_transaction(struct dlg_cell* dlg, int type, struct dlg_
 	memset(&info, 0, sizeof(siptrace_info_t));
 	info.correlation_id = dlgb.get_dlg_var(dlg, &siptrace_info_dlgkey);
 
+	/**
+	 * DUAL BYE - internally generated BYE from kamailio
+	 * set flag to signal request_in callback which will register
+	 * transaction callbacks to catch caller and callee BYEs and their
+	 * responses
+	 */
+	if (params->req == NULL && params->rpl == NULL) {
+		LM_DBG("dual bye!\n");
+		return;
+	}
+
 	trace_transaction(params->req, &info, 0);
 
 	sip_trace(params->req, NULL, info.correlation_id, NULL);