[sr-dev] [kamailio/kamailio] usrloc: cleanup by server_id. (#1480)

[Daniel-Constantin Mierla]

miconda commented on this pull request.



>  	if (ul_dbf.use_table(ul_dbh, _d->name) < 0) {
 		LM_ERR("use_table failed\n");
 		return -1;
 	}
+	
+	if (ul_db_srvid != 0) {
+		key_num = 3;
+	}
 

I think it is better to move this `if` bloc at line 913 above and have those assignements for keys/ops/vals with index `[2]` inside it. It is better to see have related operations grouped together, avoiding also useless operations if ul_db_srvid is 0.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1480#pullrequestreview-103018005
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180312/629f8ce7/attachment.html>