<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1480#discussion_r173776004">src/modules/usrloc/udomain.c</a>:</p>
<pre style='color:#555'>>      if (ul_dbf.use_table(ul_dbh, _d->name) < 0) {
                LM_ERR("use_table failed\n");
                return -1;
        }
+       
+       if (ul_db_srvid != 0) {
+               key_num = 3;
+       }
 
</pre>
<p>I think it is better to move this <code>if</code> bloc at line 913 above and have those assignements for keys/ops/vals with index <code>[2]</code> inside it. It is better to see have related operations grouped together, avoiding also useless operations if ul_db_srvid is 0.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1480#pullrequestreview-103018005">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZSPv1Na6D5y_x1zxhqTGgxDNdKoCks5tdmdJgaJpZM4Sma2W">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZajG27CcMwVivA2EGHpKe-2eveZeks5tdmdJgaJpZM4Sma2W.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1480#pullrequestreview-103018005"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda commented on #1480"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1480#pullrequestreview-103018005"}}}</script>