[sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: sec-agree implementation for IMS (#1605)

[Henning Westerholt]

Hello,
thank you for your contribution! I did a quick look to the code and noticed a few simple areas that should refined before going looking deeper in the functionality.

* Please remove the README file from the commit. This is auto-generated and should not be commited to git
* You mentioned that your work is based on OpenIMScore. Do you actually use code from this project in your implementation? Then you need to add proper copyright notices that refer to this code.
* With regards to copyright - you need to also choose a copyright to your code. Most modules choose "GPLv2 and later", but BSD would be also ok if you prefer this. Have a look to other modules for an  example copyright header.

Best regards,
Henning

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1605#issuecomment-408609505
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180728/29a85341/attachment.html>