[sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: sec-agree implementation for IMS (#1605)

[Tsvetomir Dimitrov]

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

This is an implementation of sec-agree used in IMS with IPSec. It's not a complete sec-agree implementation, only the flows used by IMS. The code is usable, but needs a few improvements, which I plan to push in the near future. **My work is based on the implementation in OpenIMSCore.**

For IPSec implementation the XFRM framework from the Linux kernel is used. Security association (SA) and Policies creation/removal is performed via netlink messages. For this reason the module depends on libmnl (a minimalistic netlink library).

As XFRM is Linux specific, the code is not portable and can't be used on operating system different from Linux. The code will not compile on *BSDs too. However all platform specific code resides in ipsec.c so support for other OSes/IPSec implementations can be added relatively easy.

The README file, which is commited is generated from docs dir with xsltproc.

Issues I still work on:
- Kamailio must be run as root in order to be able to send netlink messages and create XFRM SAs and Policies.
- SAs and Policies are not deleted on Kamailio startup and shutdown.
- According to the current contact implementation in the PCSCF modules (adn the 3GPP specs) the IPSec tunnel should be created on two steps. Initial parameters should be saved in security_tmp and on confirmation - in security. At the moment everything remains in security.

As this is my first more serious contribution to the project, all kinds of feedback is highly appreciated :)
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1605

-- Commit Summary --

  * ims_ipsec_pcscf: sec-agree implementation for IMS

-- File Changes --

    A src/modules/ims_ipsec_pcscf/Makefile (20)
    A src/modules/ims_ipsec_pcscf/README (244)
    A src/modules/ims_ipsec_pcscf/cmd.c (585)
    A src/modules/ims_ipsec_pcscf/cmd.h (6)
    A src/modules/ims_ipsec_pcscf/doc/Makefile (4)
    A src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf.xml (88)
    A src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (231)
    A src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (227)
    A src/modules/ims_ipsec_pcscf/ipsec.c (386)
    A src/modules/ims_ipsec_pcscf/ipsec.h (24)
    A src/modules/ims_ipsec_pcscf/run_spi_list_tests.sh (4)
    A src/modules/ims_ipsec_pcscf/spi_gen.c (87)
    A src/modules/ims_ipsec_pcscf/spi_gen.h (16)
    A src/modules/ims_ipsec_pcscf/spi_list.c (123)
    A src/modules/ims_ipsec_pcscf/spi_list.h (29)
    A src/modules/ims_ipsec_pcscf/spi_list_tests.c (292)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1605.patch
https://github.com/kamailio/kamailio/pull/1605.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180727/a2fccbd8/attachment.html>