[sr-dev] [kamailio/kamailio] topos: adding param contact_hostname (#1596)

Julien Chavanton notifications at github.com
Sat Jul 28 02:02:45 CEST 2018


I think it is better to use the contact header param only taking optional port and transport from it.
And not use the Record route information at all this way we support NAPTR/SRV and things are less confusing for the user.

Thanks for the pointing this out, it was not my intent to use the port + transport from the RR.

I will : 
- update the PR and the doc too explicitly state that the host part can also contain params.
- parse the module contact param in mod_init and fail if is it invalid.
- make sure we are not using puri.port and puri.transport from the RR
- do a few tests

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1596#issuecomment-408566488
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180727/43288255/attachment.html>


More information about the sr-dev mailing list