<p>I think it is better to use the contact header param only taking optional port and transport from it.<br>
And not use the Record route information at all this way we support NAPTR/SRV and things are less confusing for the user.</p>
<p>Thanks for the pointing this out, it was not my intent to use the port + transport from the RR.</p>
<p>I will :</p>
<ul>
<li>update the PR and the doc too explicitly state that the host part can also contain params.</li>
<li>parse the module contact param in mod_init and fail if is it invalid.</li>
<li>make sure we are not using puri.port and puri.transport from the RR</li>
<li>do a few tests</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1596#issuecomment-408566488">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZaWqH6RSKL4MA8GB-UOkmueMCTaZks5uK6olgaJpZM4VTjsO">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZVnryMzX65VHQs5mB4r19DdqYHBpks5uK6olgaJpZM4VTjsO.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jchavanton in #1596: I think it is better to use the contact header param only taking optional port and transport from it.\r\nAnd not use the Record route information at all this way we support NAPTR/SRV and things are less confusing for the user.\r\n\r\nThanks for the pointing this out, it was not my intent to use the port + transport from the RR.\r\n\r\nI will : \r\n- update the PR and the doc too explicitly state that the host part can also contain params.\r\n- parse the module contact param in mod_init and fail if is it invalid.\r\n- make sure we are not using puri.port and puri.transport from the RR\r\n- do a few tests"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1596#issuecomment-408566488"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1596#issuecomment-408566488",
"url": "https://github.com/kamailio/kamailio/pull/1596#issuecomment-408566488",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] topos: adding param contact_hostname (#1596)",
"sections": [
{
"text": "",
"activityTitle": "**Julien Chavanton**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jchavanton",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1596,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1596\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1596#issuecomment-408566488"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 357448462\n}"
}
],
"themeColor": "26292E"
}
]</script>