[sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

Emmanuel Schmidbauer notifications at github.com
Tue Jan 30 19:55:32 CET 2018


the problem i see with this:
```
int _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename)
{
	return pres_refresh_watchers(pres, event, type, file_uri, filename);
}
``` 
is the last 2 parameters are option, yet you have no way of knowing that by looking at the API function. therefore the API function becomes confusing. and another developer could spend a lot of time parsing through the code to figure out which params are required and which are optional (much like i just had to do in order to implement these 2 API functions). it will save developers a lot more time to create API functions with *only* required parameters

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1417#issuecomment-361696738
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180130/b47b80ce/attachment.html>


More information about the sr-dev mailing list