<p>the problem i see with this:</p>
<pre><code>int _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename)
{
        return pres_refresh_watchers(pres, event, type, file_uri, filename);
}
</code></pre>
<p>is the last 2 parameters are option, yet you have no way of knowing that by looking at the API function. therefore the API function becomes confusing. and another developer could spend a lot of time parsing through the code to figure out which params are required and which are optional (much like i just had to do in order to implement these 2 API functions). it will save developers a lot more time to create API functions with <em>only</em> required parameters</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1417#issuecomment-361696738">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZZnoYjJybaV7Drf8-g_XXvX_uwFrks5tP2WkgaJpZM4RxGM7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Zaf6FF9QMXAXN94BSUq_cwxpS7cDks5tP2WkgaJpZM4RxGM7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1417#issuecomment-361696738"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eschmidbauer in #1417: the problem i see with this:\r\n```\r\nint _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename)\r\n{\r\n\treturn pres_refresh_watchers(pres, event, type, file_uri, filename);\r\n}\r\n``` \r\nis the last 2 parameters are option, yet you have no way of knowing that by looking at the API function. therefore the API function becomes confusing. and another developer could spend a lot of time parsing through the code to figure out which params are required and which are optional (much like i just had to do in order to implement these 2 API functions). it will save developers a lot more time to create API functions with *only* required parameters"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1417#issuecomment-361696738"}}}</script>