[sr-dev] [kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)

[Christoph VALENTIN]

Hi,

Can you do it the way you proposed? I’d have to create a new branch for this anyway.

KR

From: Daniel-Constantin Mierla [mailto:notifications at github.com]
Sent: Thursday, January 25, 2018 2:46 PM
To: kamailio/kamailio <kamailio at noreply.github.com>
Cc: Valentin Christoph <Christoph.Valentin at kapsch.net>; Author <author at noreply.github.com>
Subject: Re: [kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)


Thanks for finding this, looks like a copy&paste issue, so I think the condition should not be removed but fixed -- instead of:

if(subs->extra_headers && hentity->extra_headers->s)

There should be:

if(subs->extra_headers && subst->extra_headers->s)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/kamailio/kamailio/pull/1409#issuecomment-360470585>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AcOqyInFopeBjB3PammlkF94ZwU4azDRks5tOIWfgaJpZM4Rs1nY>.



The information contained in this e-mail message is privileged and confidential and is for the exclusive use of the addressee. The person who receives this message and who is not the addressee, one of his employees or an agent entitled to hand it over to the addressee, is informed that he may not use, disclose or reproduce the contents thereof, and is kindly asked to notify the sender and delete the e-mail immediately.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1409#issuecomment-360471259
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180125/293a43df/attachment.html>