Hi,
<br>

<br>
Can you do it the way you proposed? I’d have to create a new branch for this anyway.
<br>

<br>
KR
<br>

<br>
From: Daniel-Constantin Mierla [mailto:notifications@github.com]
<br>
Sent: Thursday, January 25, 2018 2:46 PM
<br>
To: kamailio/kamailio <kamailio@noreply.github.com>
<br>
Cc: Valentin Christoph <Christoph.Valentin@kapsch.net>; Author <author@noreply.github.com>
<br>
Subject: Re: [kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)
<br>

<br>

<br>
Thanks for finding this, looks like a copy&paste issue, so I think the condition should not be removed but fixed -- instead of:
<br>

<br>
if(subs->extra_headers && hentity->extra_headers->s)
<br>

<br>
There should be:
<br>

<br>
if(subs->extra_headers && subst->extra_headers->s)
<br>

<br>
—
<br>
You are receiving this because you authored the thread.
<br>
Reply to this email directly, view it on GitHub<https://github.com/kamailio/kamailio/pull/1409#issuecomment-360470585>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AcOqyInFopeBjB3PammlkF94ZwU4azDRks5tOIWfgaJpZM4Rs1nY>.
<br>
<br>
<br>
<br>
The information contained in this e-mail message is privileged and confidential and is for the exclusive use of the addressee. The person who receives this message and who is not the addressee, one of his employees or an agent entitled to hand it over to the addressee, is informed that he may not use, disclose or reproduce the contents thereof, and is kindly asked to notify the sender and delete the e-mail immediately.<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1409#issuecomment-360471259">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZfHtg25ojqMVJNNrU9JiWqqWUeg4ks5tOIY7gaJpZM4Rs1nY">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Zc7JrCNQdyRjX3cjyVSYD2a5oYXnks5tOIY7gaJpZM4Rs1nY.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1409#issuecomment-360471259"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@christoph-v in #1409: Hi,\r\n\r\nCan you do it the way you proposed? I’d have to create a new branch for this anyway.\r\n\r\nKR\r\n\r\nFrom: Daniel-Constantin Mierla [mailto:notifications@github.com]\r\nSent: Thursday, January 25, 2018 2:46 PM\r\nTo: kamailio/kamailio \u003ckamailio@noreply.github.com\u003e\r\nCc: Valentin Christoph \u003cChristoph.Valentin@kapsch.net\u003e; Author \u003cauthor@noreply.github.com\u003e\r\nSubject: Re: [kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)\r\n\r\n\r\nThanks for finding this, looks like a copy\u0026paste issue, so I think the condition should not be removed but fixed -- instead of:\r\n\r\nif(subs-\u003eextra_headers \u0026\u0026 hentity-\u003eextra_headers-\u003es)\r\n\r\nThere should be:\r\n\r\nif(subs-\u003eextra_headers \u0026\u0026 subst-\u003eextra_headers-\u003es)\r\n\r\n—\r\nYou are receiving this because you authored the thread.\r\nReply to this email directly, view it on GitHub\u003chttps://github.com/kamailio/kamailio/pull/1409#issuecomment-360470585\u003e, or mute the thread\u003chttps://github.com/notifications/unsubscribe-auth/AcOqyInFopeBjB3PammlkF94ZwU4azDRks5tOIWfgaJpZM4Rs1nY\u003e.\r\n\n\n\nThe information contained in this e-mail message is privileged and confidential and is for the exclusive use of the addressee. The person who receives this message and who is not the addressee, one of his employees or an agent entitled to hand it over to the addressee, is informed that he may not use, disclose or reproduce the contents thereof, and is kindly asked to notify the sender and delete the e-mail immediately.\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1409#issuecomment-360471259"}}}</script>