[sr-dev] git:master:a8de371e: auth_db: print db table name when version check fails

[Henning Westerholt]

Am Freitag, 28. Dezember 2018, 16:23:49 CET schrieb Daniel-Constantin Mierla:
> I am fine to try to make them coherent, if you think of some solution,
> propose it here and we can discuss and eventually improve, should
> someone else have other ideas.

Hi Daniel,

the table name and version information are already logged in the core helper 
function. To log more information in the module context, my suggestion would 
be to add a macro to the DB1 API, like this:

DB_TABLE_VERSION_ERROR(l, m) LM_ERR("Error during version check for db table: 
%.*s, check database structure.\n", l, m)

>> Dec 21 16:34:31 ip-10-101-2-78 kamailio[8501]: 0(8503) ERROR: <core> [db.c:
>> 450]: db_check_table_version(): invalid version 6 for table sipusers found, 
>> expected 7 (check table structure and table "version")
>> Dec 21 16:34:31 ip-10-101-2-78 kamailio[8501]: 0(8503) ERROR: auth_db 
>> [auth_db_mod.c:308]: auth_fixup(): error during table version check.

Then we could convert all the DB modules to use this macro and can easily 
change it in the future, if we need more information.

Best regards,

Henning

-- 
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
Kamailio security assessment - https://skalatan.de/de/assessment