[sr-dev] git:master:a8de371e: auth_db: print db table name when version check fails

[Daniel-Constantin Mierla]

Hello,

I am fine to try to make them coherent, if you think of some solution,
propose it here and we can discuss and eventually improve, should
someone else have other ideas.

Cheers,
Daniel

On 26.12.18 13:37, Henning Westerholt wrote:
> Am Mittwoch, 26. Dezember 2018, 12:05:41 CET schrieb Daniel-Constantin Mierla:
>> Module: kamailio
>> Branch: master
>> Commit: a8de371e90ddc8a6921b5bf7464961865804cc06
>> URL:
>> https://github.com/kamailio/kamailio/commit/a8de371e90ddc8a6921b5bf74649618
>> 65804cc06
>>
>> Author: Daniel-Constantin Mierla <miconda at gmail.com>
>> Committer: Daniel-Constantin Mierla <miconda at gmail.com>
>> Date: 2018-12-26T12:04:59+01:00
>>
>> auth_db: print db table name when version check fails
> Hello,
>
> the table name and expected versions are already logged in the 
> db_check_table_version() inside DB1 API, e.g:
>
> Dec 21 16:34:31 ip-10-101-2-78 kamailio[8501]: 0(8503) ERROR: <core> [db.c:
> 450]: db_check_table_version(): invalid version 6 for table sipusers found, 
> expected 7 (check table structure and table "version")
> Dec 21 16:34:31 ip-10-101-2-78 kamailio[8501]: 0(8503) ERROR: auth_db 
> [auth_db_mod.c:308]: auth_fixup(): error during table version check.
>
> I checked quickly other modules, at the moment this is not done consistently. 
> Some modules just log an error, some give more detailed log message.
>
> It probably would make sense to unify it, any comments on this?
>
> Best regards,
>
> Henning
>
-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - May 6-8, 2019 -- www.kamailioworld.com
Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA -- www.asipto.com