[sr-dev] [kamailio/kamailio] define flag_t as unsigned long (#1288)

Juha Heinanen jh at tutpro.com
Thu Apr 5 09:55:10 CEST 2018


Daniel-Constantin Mierla writes:

> The purpose of that t_flush_flags() is documented:
> 
>   * https://www.kamailio.org/docs/modules/stable/modules/tmx.html#tmx.f.t_flush_flags
> 
> The role was to push the flags set after t_newtran() to
> transaction. If that is not happening/is not needed for what so ever
> reason, needs to be sorted out in a way or another.

Yes, and that is the topic of #1490.

> The behaviour can stay as it is, with or without any new parameter --
> this is going to be discussed. But again, it doesn't belong here, the
> issue we discuss is with flushing the flags after t_newtrans() and
> should be done in a single place. The xflags will follow whatever is
> decided for t_flush_flags(), but right now xflags works as it is
> expected based on docs for t_flush_flags().

> Let's discuss further on #1490 and get the two work the same in a
> properly documented behaviour.

OK, I'll close this issue with the note that the current semantics of
xflags does not correspond to that of flags.

-- Juha



More information about the sr-dev mailing list