[sr-dev] [kamailio/kamailio] core: allow 64-bit integer when checking version number (#1186)

Daniel-Constantin Mierla notifications at github.com
Wed Jul 12 20:47:50 CEST 2017


The description of the pull request/patch is wrong then, because DB1_DOUBLE is a floating point, not an integer.

Eventually you can add support for both DB1_BIGINT and DB1_DOUBLE. However, few remarks:

  * use if-else, to be more optimal and avoid unnecessary evaluations of conditions, with check for DB1_INT being the first
  * for DB1_BIGINT and DB1_DOUBLE do cast to (int), otherwise there will be warnings on strict compilers

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#issuecomment-314861716
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20170712/ee367589/attachment.html>


More information about the sr-dev mailing list