<p>The description of the pull request/patch is wrong then, because DB1_DOUBLE is a floating point, not an integer.</p>
<p>Eventually you can add support for both DB1_BIGINT and DB1_DOUBLE. However, few remarks:</p>
<ul>
<li>use if-else, to be more optimal and avoid unnecessary evaluations of conditions, with check for DB1_INT being the first</li>
<li>for DB1_BIGINT and DB1_DOUBLE do cast to (int), otherwise there will be warnings on strict compilers</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1186#issuecomment-314861716">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36Zc3a183OOzKL9hQscZBBxOy9UvOoks5sNRTWgaJpZM4OV7-Y">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZTN9eb3GDmC_dtbrX3fWqh00Zej-ks5sNRTWgaJpZM4OV7-Y.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1186#issuecomment-314861716"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1186: The description of the pull request/patch is wrong then, because DB1_DOUBLE is a floating point, not an integer.\r\n\r\nEventually you can add support for both DB1_BIGINT and DB1_DOUBLE. However, few remarks:\r\n\r\n  * use if-else, to be more optimal and avoid unnecessary evaluations of conditions, with check for DB1_INT being the first\r\n  * for DB1_BIGINT and DB1_DOUBLE do cast to (int), otherwise there will be warnings on strict compilers"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1186#issuecomment-314861716"}}}</script>