[sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

[Daniel-Constantin Mierla]

miconda commented on this pull request.



> @@ -1061,3 +1067,57 @@ int redis_count_err_and_disable(redisc_server_t *rsrv)
 	}
 	return 0;
 }
+
+void print_redis_reply(int log_level, redisReply *rpl,int offset)
+{
+	int i;
+	char padding[MAXIMUM_NESTED_KEYS + 1];
+
+	if (redis_get_debug_level() < log_level)
+		return;
+

I think that instead of the above IF condition you can use:

```
if(!is_printable(log_level))
```

so redis_get_debug_level() is not needed at all.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1175#pullrequestreview-47661434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20170703/e9bddaa9/attachment.html>