<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1175#discussion_r125286609">src/modules/ndb_redis/redis_client.c</a>:</p>
<pre style='color:#555'>> @@ -1061,3 +1067,57 @@ int redis_count_err_and_disable(redisc_server_t *rsrv)
        }
        return 0;
 }
+
+void print_redis_reply(int log_level, redisReply *rpl,int offset)
+{
+       int i;
+       char padding[MAXIMUM_NESTED_KEYS + 1];
+
+       if (redis_get_debug_level() < log_level)
+               return;
+
</pre>
<p>I think that instead of the above IF condition you can use:</p>
<pre><code>if(!is_printable(log_level))
</code></pre>
<p>so redis_get_debug_level() is not needed at all.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1175#pullrequestreview-47661434">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZbDCk1S_sUXiVRlEyFkjMKvOkBw7ks5sKOlUgaJpZM4OMQpS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZdyMXsmd9T8G_7UIzZQTcBfpICX4ks5sKOlUgaJpZM4OMQpS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1175#pullrequestreview-47661434"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda commented on #1175"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1175#pullrequestreview-47661434"}}}</script>