[sr-dev] http_async

Olle E. Johansson oej at edvina.net
Thu Feb 4 15:30:34 CET 2016


> On 04 Feb 2016, at 12:23, Camille Oudot <camille.oudot at orange.com> wrote:
> 
> Hi Olle,
> 
> thanks for your feedback. We're going to fix the documentation issues
> you spotted.
> 
>> - Add a note about the need to load TLS module first (like I just did
>> in http_client docs)
> 
> The openssl library initialization is done by the tls module before any
> other mod_init(), so as far as I understand it, the load order does not
> matter.
> 
> To me, the real concern is that the openssl library will be initialized
> several times if several modules or libraries want to use openssl in
> the same process space (this is the case for example when using the TLS
> module and another module using libcurl).
It was Daniel’s recommendation to load the TLS module first since he
had fixed some generic OpenSSL magic there.

> 
>> - http_set_ssl_cert should have “tls” instead of “ssl”. SSL is bad.
> 
> We spoke about this one, "ssl" reflects the names int the curl API. If
> we totally disable SSL though, it makes sense to use "tls”.
Exactly.

> 
>> - I still think we need to discuss the way you have to run functions
>> to set parameters for a coming function call.
>> (...)
>> What if that function doesn’t happen, will all these values be reset
>> for the next message processed in that process?
> 
> Good point, that is not addressed yet: we have to figure a way to reset
> all the values previously set when a new message is processed.
> Currently, they are reset when the HTTP query is sent.

And I think you need to rethink the way you handle this. We are quite
open for new ideas, but adding a totally new scheme for setting parameters for
function calls is not something we need - it will just be confusing for
people who learn Kamailio. Please try to use an existing framework.

Sorry for being really, really, really stubborn of this, but I’ve spent
over 10 years doing Kamailio trainings… :-)

/O
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2374 bytes
Desc: not available
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20160204/9617aad9/attachment.bin>


More information about the sr-dev mailing list