[sr-dev] nathelper patch re. alias being added twice

[Jason Penton]

Hey Daniel,

The problem in the case I have noticed is that some UEs are taking the
contact from the 200OK and all subsequent requests from the UEs have the
alias in (when leaving UE). This causes problems in the routing as a result
of the same alias being added multiple times.....

If you are happy with the general concept I'd like to add this patch but
with addition of:
1. configurable parameter to enable (disabled by default)
2. make the check more intelligent to check you are not adding *exactly*
the same alias again.... (which would be pointless)

?

Cheers
Jason

On Thu Jan 08 2015 at 12:34:30 Daniel-Constantin Mierla <miconda at gmail.com>
wrote:

>  Hello,
>
> there are two functions, add_contact_alias() and set_contact_alias(), fist
> added by Juha and the second by me.
>
> Is that really needed, because if couple of sip nodes add that parameter,
> then expect that each node will handle it.
>
> A --- P1 --- P2 --- P3 --- B
>
> If P1 is adding by P2 is processing as well, then it will mess up routing.
> I think by the order they are added, they are going to be processed ok even
> many nodes are adding it.
>
> If there is no safe around detecting if alias was added locally in
> handle_ruri_alias(), then this patch behaviour should be made configurable
> if still wanted.
>
> Cheers,
> Daniel
>
>
> On 08/01/15 09:09, Jason Penton wrote:
>
> Hi,
>
>  I assume this will be for Juha or Maxim, but I would like to suggest the
> following patch for nathelper to ensure that the alias is not added if it
> already exists in the contact uri.
>
>  Juha, Maxim as this is your module are you happy with this?
>
>  Cheers
> Jason
>
>  --
>
>     *Jason Penton*  *Senior Manager: Applications and Services*  *Smile
> Communications Pty (Ltd)*    *Mobile:* +27 (0) 83 283 7000  *Skype:*
> jason.barry.penton    jason.penton at smilecoms.com
> <name.surname at smilecoms.com>  www.smilecoms.com
>
>
>
>  This email is subject to the disclaimer of Smile Communications at http://www.smilecoms.com/home/email-disclaimer/
>
>
>
> _______________________________________________
> sr-dev mailing listsr-dev at lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
> --
> Daniel-Constantin Mierlahttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>
>  _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150108/0eebfa42/attachment.html>