[sr-dev] nathelper patch re. alias being added twice

[Daniel-Constantin Mierla]

Hello,

there are two functions, add_contact_alias() and set_contact_alias(),
fist added by Juha and the second by me.

Is that really needed, because if couple of sip nodes add that
parameter, then expect that each node will handle it.

A --- P1 --- P2 --- P3 --- B

If P1 is adding by P2 is processing as well, then it will mess up
routing. I think by the order they are added, they are going to be
processed ok even many nodes are adding it.

If there is no safe around detecting if alias was added locally in
handle_ruri_alias(), then this patch behaviour should be made
configurable if still wanted.

Cheers,
Daniel

On 08/01/15 09:09, Jason Penton wrote:
> Hi,
>
> I assume this will be for Juha or Maxim, but I would like to suggest
> the following patch for nathelper to ensure that the alias is not
> added if it already exists in the contact uri.
>
> Juha, Maxim as this is your module are you happy with this?
>
> Cheers
> Jason
>
> -- 
>
> *Jason Penton*
> *Senior Manager: Applications and Services*
> *Smile Communications Pty (Ltd)*
> *Mobile:* 	+27 (0) 83 283 7000
> *Skype:* 	jason.barry.penton
>
> jason.penton at smilecoms.com <mailto:name.surname at smilecoms.com>
> www.smilecoms.com <http://www.smilecoms.com/>
>
>
>
> This email is subject to the disclaimer of Smile Communications at http://www.smilecoms.com/home/email-disclaimer/ <http://www.smilecoms.com/home/email-disclaimer/>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150108/9f64788f/attachment-0001.html>