[sr-dev] kazoo module updates & documentation

[Luis Azedo]

Hi Daniel,

please take a look at msg_presentity_clean function in publish.c module presence.

if the initial query returns a result
if pres_notifier_processes = 0 (immediate notify)
it calls publ_notify function
in publ_notify function in notify.c
if(p->event->agg_nbody) // dialoginfo aggregates the results
{
notify_body = get_p_notify_body(pres_uri, p->event , offline_etag, NULL);
         .....
get_p_notify_body queries the presentity table to get other records to aggregate body
which will override the result in the connection.

so the process is the same but it calls the query 2 times in a row without freeing the 1st result.




________________________________
From: sr-dev-bounces at lists.sip-router.org [sr-dev-bounces at lists.sip-router.org] on behalf of Daniel-Constantin Mierla [miconda at gmail.com]
Sent: Friday, September 12, 2014 12:15 PM
To: Kamailio (SER) - Development Mailing List
Subject: Re: [sr-dev] kazoo module updates & documentation

Hello,

changes to kazoo modules are ok, you can merge them.

But the one for db_text I don't find it (yet) necessary, because it may solve an issue in a wrong way.

I asked you to push the other patch on db_text related to blob type handling in freeing the value. That can be done. For the one storing the result on db_res variable, I will comment separately.

Daniel

On 12/09/14 20:55, Luis Azedo wrote:
Hi,

i would like to propose the small changes to the kazoo module in branch lazedo/kazoo to go into master.
it's mostly code cleanup & dependency removal.

also added the documentation on that branch and would appreciate any feedback.


there is also a patch to the db_text module. the comment on that commit tells the reason for that patch.

Thanks




_______________________________________________
sr-dev mailing list
sr-dev at lists.sip-router.org<mailto:sr-dev at lists.sip-router.org>
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev



--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Next Kamailio Advanced Trainings 2014 - http://www.asipto.com
Sep 22-25, Berlin, Germany
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140913/23e9254c/attachment-0001.html>