[sr-dev] XMLRPC seg fault

[Jason Penton]

Hi Juha,

Okay I have found the root cause....

If the XML data for string parameters is sent in as follows:

<?xml version="1.0"
encoding="UTF-8"?><methodCall><methodName>ulscscf.showimpu</methodName><params><param><value>
<string>somestring</string></value></param></params></methodCall>

then everything is fine. BUT, if you send the following (viz. string tags
omitted - done by default in JAVA XML:

<?xml version="1.0"
encoding="UTF-8"?><methodCall><methodName>ulscscf.showimpu</methodName><params><param><value>somestring</value></param></params></methodCall>

you will get a segfault.

Ideally we should return a fault string here - if "parsing" fails in
xmllibrary...

Cheers
Jason


On Mon, May 19, 2014 at 6:52 PM, Jason Penton <jason.penton at gmail.com>wrote:

> Hi Juha,
>
> There is a via. The message is handled correctly and in fact responded to
> correctly, but the seg fault happens very soon after. I have localized the
> problem to passing in a parameter in the RPC input request.
>
> As soon as code has something like the following before the RPC response,
> it crashes.....
>
> str impu;
> if (rpc->scan(ctx, "S", &impu) < 1) {
>  rpc->fault(ctx, 400, "required IMPU argument");
> return;
> }
>
> if I remove the above, and hardwire the return RPC values/data, everything
> is fine, add it back, even if not being used, and crash is back.
>
>
>
>
>
>
>
> On Mon, May 19, 2014 at 5:51 PM, Juha Heinanen <jh at tutpro.com> wrote:
>
>> Jason Penton writes:
>>
>> > Sorry, I sent the incorrect bt,
>>
>> based on the new bt is looks like the incoming xmlrpc request does not
>> have via header and crash happens when that non-existent via header is
>> freed.
>>
>> do you have ngrep of the request?
>>
>> -- juha
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140519/8c34727e/attachment.html>