[sr-dev] PARAM_STR vs STR_PARAM

[Alekzander Spiridonov]

Got it. Patch should work.


2014-07-21 16:19 GMT+04:00 Daniel-Constantin Mierla <miconda at gmail.com>:

>  If you use the git repository from sip-router.org, there is no way to
> make pull requests. You would have to send the patches to mailing list or
> upload to tracker (you can commit them locally and then export them in
> dedicated files using git format-patch --
> http://stackoverflow.com/questions/6658313/generate-a-git-patch-for-a-specific-commit
> ).
>
> Or you can use the mirror on github, fork it from there, announce here or
> make a pull request when done, then I will review and merge the patches.
>
> Cheers,
> Daniel
>
>
> On 21/07/14 14:06, Alekzander Spiridonov wrote:
>
> Daniel,
>
> What's the contributing policy here? I'm not able to create a pulling
> request without either pushing a new branch or pushing a changes to any
> existing one.
>
>
> 2014-07-18 20:02 GMT+04:00 Alekzander Spiridonov <alekz at li.ru>:
>
>> Hmmm.. What's the way of pushing a new branch to github?
>>
>>
>> 2014-07-18 12:50 GMT+04:00 Daniel-Constantin Mierla <miconda at gmail.com>:
>>
>>  I prefer one per module, because it is easier to review and keeps the
>>> history cleaner for that module.
>>>
>>> Thanks,
>>> Daniel
>>>
>>>
>>> On 18/07/14 10:45, Alekzander Spiridonov wrote:
>>>
>>> Should I submit patch per module or one for all? Actually there are
>>> numerous cases in kamailio/modules/*
>>>
>>>
>>> 2014-07-17 22:58 GMT+04:00 Daniel-Constantin Mierla <miconda at gmail.com>:
>>>
>>>> Hello,
>>>>
>>>>
>>>> On 09/07/14 11:00, Alekzander Spiridonov wrote:
>>>>
>>>>> Hi list,
>>>>>
>>>>> While going through mod_init's and finding things like
>>>>> rtpp_table_name.len = strlen(rtpp_table_name.s);
>>>>>
>>>>> I became curious if using of deprecated STR_PARAM in new modules is
>>>>> done on purpose. Why not using PARAM_STR for string module parameters?
>>>>>
>>>>> Quote from sr_module.h:
>>>>> #define PARAM_STRING     (1U<<0)  /**< String (char *) parameter type
>>>>> */
>>>>> #define PARAM_STR        (1U<<2)  /**< struct str parameter type */
>>>>> #define STR_PARAM PARAM_STRING
>>>>>
>>>>> P.S.: That's not only about curiosity but to avoid any bugs in my
>>>>> kamailio extensions.
>>>>>
>>>>  Indeed PARAM_STR should be used if the value of the parameter needs
>>>> to be stored in a str structure.
>>>>
>>>> PARAM_STR was introduced by SER developers before joining back with
>>>> Kamailio source code, so many developers are not aware of it.
>>>>
>>>> We should review and migrate in such cases.
>>>>
>>>> Cheers,
>>>> Daniel
>>>>
>>>> --
>>>> Daniel-Constantin Mierla - http://www.asipto.com
>>>> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>>>>
>>>>
>>>> _______________________________________________
>>>> sr-dev mailing list
>>>> sr-dev at lists.sip-router.org
>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>>
>>>
>>>
>>>
>>> --
>>>  Best regards,
>>> Alekzander Spiridonov
>>>
>>>
>>>
>>> _______________________________________________
>>> sr-dev mailing listsr-dev at lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>
>>>
>>> --
>>> Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>>>
>>>
>>> _______________________________________________
>>> sr-dev mailing list
>>> sr-dev at lists.sip-router.org
>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>
>>>
>>
>>
>> --
>>  Best regards,
>> Alekzander Spiridonov
>>
>>
>
>
> --
>  Best regards,
> Alekzander Spiridonov
>
>
> --
> Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>
>


-- 
Best regards,
Alekzander Spiridonov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140721/7ce244a6/attachment.html>