[sr-dev] WebSockets broken?

[Peter Dunkley]

I don't have a commit ID for it working as the system that is working 
was installed from RPMs.  However, It was compiled at 18:39:25 (BST) on 
May 20 2013.

It will have been a clean pull from Git at the time it was built.

Peter

On 30/05/13 17:36, Daniel-Constantin Mierla wrote:
>
> On 5/30/13 6:17 PM, Peter Dunkley wrote:
>> When latest Kamailio git master sends a message over WebSocket 
>> (specifically an MSRP reply on my test system) I get the error,
>>
>>     One or more reserved bits are on: reserved1 = 1, reserved2 = 0, reserved3 = 0
>>
>> in Google Chrome.  This happens for WebSockets over TCP and 
>> WebSockets over TLS.  It doesn't happen with a build of Kamailio git 
>> master from around two weeks ago.
>>
>> Have there been any changes in the network code over the last couple 
>> of weeks that might have had an effect on what Kamailio puts out on 
>> the wire for TCP and TLS?
> I don't recall any, but if you give the commit id of the version you 
> are running and it is ok, we can check the rest of the commits till today.
>
> Cheers,
> Daniel
>>
>> The code to send an MSRP reply over WebSocket is in 
>> modules/msrp/msrp_netio.c:msrp_reply()
>>          if (unlikely((env->srcinfo.proto == PROTO_WS
>>                          || env->srcinfo.proto == PROTO_WSS)
>>                          && sr_event_enabled(SREV_TCP_WS_FRAME_OUT))) {
>>                  struct tcp_connection *con = tcpconn_get(env->srcinfo.id, 0, 0,
>>                                                                  0, 0);
>>                  ws_event_info_t wsev;
>>
>>                  if (con == NULL)
>>                  {
>>                          LM_WARN("TCP/TLS connection for WebSocket could not be"
>>                                  "found\n");
>>                          return -1;
>>                  }
>>
>>                  memset(&wsev, 0, sizeof(ws_event_info_t));
>>                  wsev.type = SREV_TCP_WS_FRAME_OUT;
>>                  wsev.buf = rplbuf;
>>                  wsev.len = p - rplbuf;
>>                  wsev.id = con->id;
>>                  return sr_event_exec(SREV_TCP_WS_FRAME_OUT, (void *) &wsev);
>>          }
>>
>> The code that handles the SREV_TCP_WS_FRAME_OUT event is in 
>> modules/websocket/ws_frame.c and basically involves:
>>
>>   * filling in the WebSocket message header
>>   * identifying the correct TCP/TLS connection
>>   * setting some flags (for example, SND_F_FORCE_CON_REUSE)
>>   * calling tcp_send()
>>
>> These areas of the code haven't been changed for months.
>>
>> Regards,
>>
>> Peter
>>
>>
>>
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
> -- 
> Daniel-Constantin Mierla -http://www.asipto.com
> http://twitter.com/#!/miconda  -http://www.linkedin.com/in/miconda
> Kamailio Advanced Training, San Francisco, USA - June 24-27, 2013
>    *http://asipto.com/u/katu  *
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20130530/47b3bff3/attachment-0001.html>